Skip to content

feat(oracle-epm-planning): add Planning and FreeForm integration - #7510

Open
BillLeoutsakosvl346 wants to merge 6 commits into
feat/oracle-epm-foundationfrom
investigate/oracle-epm-planning-integration
Open

feat(oracle-epm-planning): add Planning and FreeForm integration#7510
BillLeoutsakosvl346 wants to merge 6 commits into
feat/oracle-epm-foundationfrom
investigate/oracle-epm-planning-integration

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add Oracle EPM Planning & FreeForm as one integration, preserving the original 29 tools and adding nine for data maps, user-variable values, approvals, and IPM insights (38 total).
  • Stack on feat(oracle-epm): add guarded foundation #7469 with base feat/oracle-epm-foundation. Reuse EPM credentials, declarative routes, returned-link policies, polling, and file primitives.
  • Keep data-map clearing explicit, approval mutations separate from discovery, and insight recomputation opt-in. Summaries return documented text only.
  • Reuse existing selectors with manual-input fallbacks and the Oracle oval icon. Include 12 grounded workflow templates and generated documentation.
  • Preserve 1,000-option / 16 MiB selector limits, 16 MiB inline payloads, 8 MiB sequential upload chunks, and 100 MiB UserFile outputs. Larger exports remain in Oracle.
  • Expansion changes no foundation or shared infrastructure machinery; shared source additions are limited to tool/internal-operation registrations.

Type of Change

  • New integration and scoped capability expansion

Testing

  • Added contract and regression coverage for all 38 tools, nested data-map overrides, empty 204 updates, approval form encoding/confirmations, insight-specific slices, text summaries, incomplete results, and payload limits.
  • Independent validate-integration / validate-selector / memory-load-check reviewer approved exact head 3168260f5bbc60d57a5e9abb706c86c8dea3d1e5, covering the entire integration and foundation interactions. No unresolved integration-owned findings or foundation change requests.
  • Current-head GitHub Test and Build passed all four jobs: lint/audits/type checks/test shard 1, test shards 2 and 3, and app build. Greptile reports 5/5 on the same head. All review threads are resolved; other applicable non-Cubic checks pass.
  • No local tests, builds, lint, type checks, or audits were run. Only the existing tool-metadata and documentation generators were run locally.
  • No live Oracle tenant verification or tenant mutations. Inline fixtures derive from official Oracle documentation.
  • Test and Build requires workflow dispatch because automatic CI excludes feature-branch PR bases. Dispatched base-sensitive audits use HEAD~1, not the full foundation-to-product diff; full child-only history is inspected separately.
  • Original integration registration expectations in credential-display.test.ts and selectors/manifest.test.ts remain preserved; this expansion does not modify them.

Checklist

  • Preserves original integration and approved expansion scope
  • Tests added/updated
  • Generated projections refreshed
  • Independent reviewer agrees
  • Current-head Test and Build passes
  • Current-head Greptile confidence is 5/5
  • Foundation branch remains untouched

Final scope verification

  • Product head: 3168260f5bbc60d57a5e9abb706c86c8dea3d1e5; foundation base: 9e738a3b021bbfb2c1c065ee1a7f241a4c41fdfc.
  • Original Planning commits are preserved. Expansion stays within the approved file tree; no deviations.
  • Shared-platform follow-up, outside this PR: feature-base automatic CI coverage and an explicit base for manually dispatched diff audits. No workflow changes included.
  • Foundation PR change requests: None. Both PRs remain open and unmerged.

@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 6, 2026 12:10am UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a complete Oracle EPM Planning and FreeForm workflow integration.

  • Registers 38 operations spanning application metadata, dimensions, jobs, data transfer, files, variables, approvals, data maps, and IPM insights.
  • Adds guarded internal execution, routing, polling, upload/download, selector, schema, and response-normalization support.
  • Aligns the workflow block, tool registry, generated metadata, documentation, icon mappings, OAuth configuration, and deployment catalog.
  • Adds contract and regression coverage for operation validation, payload limits, cancellation, file cleanup, approval encoding, and insight behavior.
  • Changes since the previous review are formatting-only and preserve behavior.

Confidence Score: 5/5

The PR appears safe to merge; no actionable new issue or outstanding previous finding remains.

The changes since the previous review are formatting-only. The prior approval-policy initialization issue and malformed test declaration are fixed, while the other resolved threads were correctly conceded as false positives. The current integration remains aligned across its block, tool registry, generated projections, internal operations, selectors, and documentation.

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/oracle_epm_planning.ts Defines the workflow-facing configuration, inputs, outputs, selectors, and operation mappings for all Oracle EPM Planning capabilities; the latest changes only reformat output conditions.
apps/sim/lib/internal/oracle-epm-planning/execute-tool.ts Dispatches validated Planning operations through the shared Oracle EPM foundation and stable internal-operation boundary.
apps/sim/lib/internal/oracle-epm-planning/route-space.ts Declares guarded Oracle route policies, including validation-only handling for returned approval links.
apps/sim/lib/internal/oracle-epm-planning/files.server.ts Implements bounded, cancellable repository uploads and downloads with temporary-resource cleanup.
apps/sim/lib/internal/oracle-epm-planning/jobs.ts Implements bounded Planning job polling with cancellation propagation and terminal-status handling.
apps/sim/lib/internal/oracle-epm-planning/execute-tool.test.ts Covers integration contracts and edge cases; the previously malformed test declaration is now complete, and the latest edits are formatting-only.
apps/sim/lib/selectors/server/providers/oracle-epm-planning.ts Provides bounded Oracle-backed selector options with manual-input fallbacks.
apps/sim/tools/oracle_epm_planning/index.ts Exports the complete 38-tool Planning and FreeForm operation set.
apps/docs/content/docs/integrations/oracle_epm_planning.mdx Documents the integration’s operations, contracts, permissions, destructive behavior, and payload limits.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  User[Workflow user] --> Block[Oracle EPM Planning block]
  Block --> Tool[Registered Planning tool]
  Tool --> Executor[Internal operation executor]
  Executor --> Route[Guarded Oracle EPM route]
  Route --> Oracle[Oracle Planning or FreeForm API]
  Oracle --> Normalize[Bounded response normalization]
  Normalize --> Output[Workflow output]
  Executor --> Files[Sim file storage]
  Executor --> Jobs[Bounded job polling]
Loading

Reviews (8): Last reviewed commit: "style(oracle-epm-planning): apply remain..." | Re-trigger Greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/lib/internal/oracle-epm-planning/files.server.ts
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/lib/internal/oracle-epm-planning/jobs.test.ts
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

Comment thread apps/sim/lib/internal/oracle-epm-planning/route-space.ts Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

Comment thread apps/sim/lib/internal/oracle-epm-planning/execute-tool.test.ts
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant